[MRG+1] Adding requests referer to RFPDupeFilter log messages #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangra
changed the title
|
@kmike if you don't see any objections, I'll merge and ship it in 1.6.0 |
|
thanks Julio. |
kmike
reviewed
Jan 28, 2019
| msg = "Filtered duplicate request: %(request)s" | ||
| self.logger.debug(msg, {'request': request}, extra={'spider': spider}) | ||
| msg = "Filtered duplicate request: %(request)s (referer: %(referer)s)" | ||
| args = {'request': request, 'referer': referer_str(request) } |
There was a problem hiding this comment.
Hey! Sorry for delay. No objections to me, a nice feature. I was just wondering if Referer should be added to the next message as well, when debug is False.
There was a problem hiding this comment.
Fair point.
I just added to keep the same behavior, but it makes sense to log referer only in debug mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just changed the log message when DUPEFILTER_DEBUG is active because it helps knowing which request is generating the duplicates (I'd this problem recently).
Also, I added some tests for the log method to check the proper messages and stats.